dtl: Support Basic Authentication for RPC endpoints#2322
dtl: Support Basic Authentication for RPC endpoints#2322Inphi merged 3 commits intoethereum-optimism:developfrom
Conversation
🦋 Changeset detectedLatest commit: 2163f1a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report
@@ Coverage Diff @@
## develop #2322 +/- ##
========================================
Coverage 80.08% 80.08%
========================================
Files 77 77
Lines 2460 2460
Branches 450 450
========================================
Hits 1970 1970
Misses 490 490
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
|
We previously only did minor releases when we did a regenesis. I'm not super opinionated on whether or not we should continue not following semver the way that it was supposed to be used |
| if (typeof this.options.l1RpcProvider === 'string') { | ||
| this.state.l1RpcProvider = FallbackProvider(this.options.l1RpcProvider, { | ||
| 'User-Agent': 'data-transport-layer', | ||
| this.state.l1RpcProvider = new StaticJsonRpcProvider({ |
There was a problem hiding this comment.
proxyd should be able to handle the retry logic now, so making this change should be fine
|
What's the context for adding auth? Is there an upstream provider that requires this? |
I see. I can make it patch in that case. We should have a discussion later about this though. |
|
|
4 participants
Description
Adds optional support for Basic Authentication for RPC endpoints.
Note: This is technically a breaking change because prior to this patch we inadvertently support multiple RPC endpoints as a csv, via the FallbackProvider. Now only a single endpoint will work.
Metadata
ENG-2062